Add docker support #936
Add docker support #936
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Deploy preview for docusaurus-preview ready! Built with commit 3094afd |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
lib/copy-examples.js
Outdated
| )}. Creating an example gitignore file for you to copy from if desired.\n` | ||
|
|
||
| const copyFileOutWebsiteFolder = (fileNameFrom, isHide) => { | ||
| let FileNameTo = isHide ? `.${fileNameFrom}` : fileNameFrom; |
There was a problem hiding this comment.
use camelCase
let fileNameTo
wszgxa
force-pushed
the
add-docker-support
branch
from
04babcb to
a1a26d1
Compare
|
done |
endiliey
force-pushed
the
add-docker-support
branch
from
b28a829 to
b00b933
Compare
|
I'll let another reviewer put approval stamp for docs nits/ etc on this before merging |
There was a problem hiding this comment.
This looks good to me. 👍 I would like @ericnakagawa to have a look at this as well.
There was a problem hiding this comment.
Looks great to me!
I contributed some light copy changes to the docs.
Thank you @wszgxa for your contribution!
Motivation
Github issue: #926
Add docker support in basic example file and doc.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
No break change, need someone to try the document. I have tested it locally.
Related PRs
nope