Handle build-files promise error & exit properly #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit 7cf8474 |
|
Yes we should! Would you like me to do it since you're on PTO? I can do it tonight. |
|
I am on PTO starting Tuesday -- but you can still do it tonight, if you would like 👍 Just let me know. |
|
Sweet! I love it when I come back to check on an issue, but a PR has already been sent, reviewed, and merged. <3 |
|
Ok I'll do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #805
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Try with https://github.com/facebook/react-native-website, delete versioned_docs/version-0.5/removing-default-permissions.md from master.
Run docusaurus build
Before
After
Try with Docusaurus, delete first doc from versioned_docs version-1.0.11 and
yarn buildBefore
After
