Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add sado0823.github.io to showcase #7584

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Conversation

sado0823
Copy link
Contributor

@sado0823 sado0823 commented Jun 9, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-7584--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 9, 2022
@netlify
Copy link

netlify bot commented Jun 9, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 9773aac
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62a192d86158d2000874deb3
😎 Deploy Preview https://deploy-preview-7584--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 81 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 87 🟢 100 🟢 100 🟢 100 🟢 90 Report

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Seems you already optimized the image—very impressive! I just resized it to 640px to be consistent with others.

@Josh-Cena Josh-Cena merged commit 79db7bc into facebook:main Jun 9, 2022
@sado0823
Copy link
Contributor Author

sado0823 commented Jun 9, 2022

💯

Seems you already optimized the image—very impressive! I just resized it to 640px to be consistent with others.

thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants