Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: wrap more JSX in mdx-code-block #7568

Merged
merged 1 commit into from
Jun 5, 2022
Merged

docs: wrap more JSX in mdx-code-block #7568

merged 1 commit into from
Jun 5, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

If we don't do this, we can't translate the tab headings because they aren't visible on Crowdin.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Jun 5, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners June 5, 2022 07:34
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 5, 2022
@netlify
Copy link

netlify bot commented Jun 5, 2022

[V2]

Name Link
🔨 Latest commit 35b35ab
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/629c5c96cbce5b0008621b3e
😎 Deploy Preview https://deploy-preview-7568--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 63 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 79 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena merged commit c03def7 into main Jun 5, 2022
@Josh-Cena Josh-Cena deleted the jc/tabs branch June 5, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants