-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add admonition type title translations #7556
Changes from 4 commits
bc03b61
fcc5451
548ffdc
37e399d
ba7b4bc
5d6bc15
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,11 @@ | |
"theme.NotFound.p2": "لطفا با صاحب وبسایت تماس بگیرید و ایشان را از مشکل پیش آمده مطلع کنید.", | ||
"theme.NotFound.title": "صفحه ای که دنبال آن بودید پیدا نشد.", | ||
"theme.TOCCollapsible.toggleButtonLabel": "مطالب این صفحه", | ||
"theme.admonition.caution": "caution", | ||
"theme.admonition.danger": "danger", | ||
"theme.admonition.info": "info", | ||
"theme.admonition.note": "note", | ||
"theme.admonition.tip": "tip", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @massoudmaboudi translations to suggest? |
||
"theme.blog.archive.description": "آرشیو", | ||
"theme.blog.archive.title": "آرشیو", | ||
"theme.blog.paginator.navAriaLabel": "کنترل لیست مطالب وبلاگ", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,11 @@ | |
"theme.NotFound.p2": "사이트 관리자에게 링크가 깨진 것을 알려주세요.", | ||
"theme.NotFound.title": "페이지를 찾을 수 없습니다.", | ||
"theme.TOCCollapsible.toggleButtonLabel": "이 페이지에서", | ||
"theme.admonition.caution": "caution", | ||
"theme.admonition.danger": "danger", | ||
"theme.admonition.info": "info", | ||
"theme.admonition.note": "note", | ||
"theme.admonition.tip": "tip", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @koko8829 @leeyspaul , translations to suggest? |
||
"theme.blog.archive.description": "게시물 목록", | ||
"theme.blog.archive.title": "게시물 목록", | ||
"theme.blog.paginator.navAriaLabel": "블로그 게시물 목록 탐색", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,11 @@ | |
"theme.NotFound.p2": "Entre em contato com o proprietário do site que lhe trouxe para cá e lhe informe que o link está quebrado.", | ||
"theme.NotFound.title": "Página não encontrada", | ||
"theme.TOCCollapsible.toggleButtonLabel": "Nessa página", | ||
"theme.admonition.caution": "caution", | ||
"theme.admonition.danger": "danger", | ||
"theme.admonition.info": "info", | ||
"theme.admonition.note": "note", | ||
"theme.admonition.tip": "tip", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @sseraphini , translations to suggest? 😄 |
||
"theme.blog.archive.description": "Arquivo", | ||
"theme.blog.archive.title": "Arquivo", | ||
"theme.blog.paginator.navAriaLabel": "Navegação da página de listagem do blog", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,11 @@ | |
"theme.NotFound.p2": "Пожалуйста, обратитесь к владельцу сайта, с которого вы перешли на эту ссылку, чтобы сообщить ему, что ссылка не работает.", | ||
"theme.NotFound.title": "Страница не найдена", | ||
"theme.TOCCollapsible.toggleButtonLabel": "Содержание этой страницы", | ||
"theme.admonition.caution": "caution", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @lex111 , want to provide translations? |
||
"theme.admonition.danger": "danger", | ||
"theme.admonition.info": "info", | ||
"theme.admonition.note": "note", | ||
"theme.admonition.tip": "tip", | ||
"theme.blog.archive.description": "Архив", | ||
"theme.blog.archive.title": "Архив", | ||
"theme.blog.paginator.navAriaLabel": "Навигация по странице списка блогов", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Warning" is used more often than "danger", at least for our docs. Do we really want to not translate it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, this is a bit annoying to have these aliases and would require duplicating some translation duplication
btw I'm not fan at all of "caution". "warning" is more natural to me.
Do we really need different default labels for both cases?
Is there a good reason to use both on our own website, or is it just historically the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that "warning" = "danger" and "caution" being another thing is not at all obvious😅 I can't even think of two distinct words for "warning" and "caution" in Chinese. Maybe we can keep it like this, since it... should be better than what we had?
TBH, on Crowdin, I never translate the admonition titles, because using "tip"/"info" is actually more natural than using any Chinese characters in the title. Maybe that's just me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forresst do you find it useful to have 2 orange admonitions for warning/caution ?
They are currently translated in French as "avertissement" / "attention", but to me we could as well use "attention" for both and it would remain a good translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slorber You are right. I agree with you. One is enough. "attention" is perfect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not good at French at all, but I struggle to capture the nuance between "warning" and "caution" in my Chinese translations. "Caution" does sound less severe than "warning". I think "avertissement" is more severe than "attention" (forgive my ignorance if that's not true)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forresst personally I find "Attention" more usual in French and would use it in both cases
I guess all this is quite subjective 🤪 hopefully it is now customizable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes, I'm misunderstanding things now.
Our alias "warning" -> "danger" feels really wrong to me. To me a warning should be yellow/orange.
BTW it looks like I'm not alone to think so
https://v1.vuepress.vuejs.org/guide/markdown.html#custom-containers
https://nextra.vercel.app/themes/docs/callout
https://vitepress.vuejs.org/guide/markdown.html#custom-containers
https://docs.gitbook.com/editing-content/rich-content/with-command-palette#hints-and-callouts
I'll open a dedicated issue, we should probably do like all others, but we need a way to migrate this gracefully or this will be annoying for our users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's very right. It has always been tricky for me as well. A breaking change is probably worth it, considering
:::warning
wasn't documented anyway...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7558