Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use npx --yes #7549

Merged
merged 2 commits into from
Jun 2, 2022
Merged

chore: use npx --yes #7549

merged 2 commits into from
Jun 2, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 2, 2022

Motivation

temp workaround for npm/cli#4619 until we use a newer node/npm version in CI matrix without this bug

Already attempted in #7167 : we can now try again thanks to Node 16 upgrade

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Jun 2, 2022
@slorber slorber requested review from lex111 and Josh-Cena as code owners June 2, 2022 11:09
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 2, 2022
@netlify
Copy link

netlify bot commented Jun 2, 2022

[V2]

Name Link
🔨 Latest commit 15b48b2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62989a63c9d13f00098f5f9a
😎 Deploy Preview https://deploy-preview-7549--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 84 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 84 🟢 99 🟢 100 🟢 100 🟢 90 Report

@@ -0,0 +1 @@
# Docusaurus core
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize the core has no README... We should definitely have something better...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 😄 also surprised

this was just for the CI anyway

@slorber
Copy link
Collaborator Author

slorber commented Jun 2, 2022

@Josh-Cena the CI path filtering is a bit too aggressive IMHO

When we commit to root package.json or other similar global things, all CIs should rather run?

In my case only a few checks did run, and I had to commit a readme to trigger more.

While I really want Windows CI to run in this case because it was the reason we didn't merge the previous PR

We probably want to include a few extra things:

  • package.json / .yarn-lock
  • jest.config.mjs

Any opinion?

@netlify
Copy link

netlify bot commented Jun 2, 2022

[V2]

Name Link
🔨 Latest commit 5d4d3ea
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62989b9ce6cc530009c84af6
😎 Deploy Preview https://deploy-preview-7549--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Josh-Cena
Copy link
Collaborator

  • package.json / yarn-lock
  • jest.config.mjs

Agree to trigger for package.json & jest config, but probably not yarn lock, because lockfile changes without package JSON changes are... not meant to be there, if you get what I mean. They do not really mean anything in practice.

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Size Change: 0 B

Total Size: 798 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.6 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 600 kB
website/build/index.html 38.9 kB

compressed-size-action

@slorber
Copy link
Collaborator Author

slorber commented Jun 2, 2022

Agree to trigger for package.json & jest config, but probably not yarn lock, because lockfile changes without package JSON changes are... not meant to be there, if you get what I mean. They do not really mean anything in practice.

Not sure what you mean here

If you decide to re-generate a lockfile without touching package.json file, and due to upgraded dependencies the build fails on Windows for some obscure reason, don't we want to catch it before merging?

@slorber slorber merged commit 7dd822b into main Jun 2, 2022
@slorber slorber deleted the slorber/restore-npm-yes branch June 2, 2022 13:07
@Josh-Cena
Copy link
Collaborator

Ah yes, that would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants