chore: update static-site-generator-webpack-plugin #7547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 798 kB ℹ️ View Unchanged
|
Josh-Cena
added
the
domain: dependencies
Josh-Cena
reviewed
Jun 2, 2022
yarn.lock
Outdated
| cheerio "^0.22.0" | ||
| eval "^0.1.8" | ||
| webpack-sources "^1.4.3" | ||
| eval "^0.1.4" |
There was a problem hiding this comment.
This range change looks a bit weird, though
There was a problem hiding this comment.
yes good catch, bad merge, will publish another version
|
Excited that we got rid of a bunch of lodash modules, bluebird, AND cheerio! |
slorber
added
the
pr: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Upgrade the dependency
@slorber/static-site-generator-webpack-pluginafter some cleanup and a few PRs mergedNew
concurrencyoption added with env variable. Not documented for now, looking for feedback before.Test Plan
site builds fine, not slower than before
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
slorber/static-site-generator-webpack-plugin#2
slorber/static-site-generator-webpack-plugin#3