Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make type-checking work in Yarn PnP #7521

Merged
merged 8 commits into from
May 28, 2022
Merged

fix: make type-checking work in Yarn PnP #7521

merged 8 commits into from
May 28, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented May 28, 2022

Pre-flight checklist

Motivation

Added a bunch of dependency declarations. node_modules size shouldn't be a big concern, since these things are now transitively installed in the init template anyway.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label May 28, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 28, 2022 14:25
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 28, 2022
@netlify
Copy link

netlify bot commented May 28, 2022

[V2]

Name Link
🔨 Latest commit 15f41c7
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6292422751a00b0008963dc9
😎 Deploy Preview https://deploy-preview-7521--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 28, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 73 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 87 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented May 28, 2022

Size Change: 0 B

Total Size: 797 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.5 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 600 kB
website/build/index.html 38.9 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 8b1acb5 into main May 28, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-pnp-tsc branch May 28, 2022 15:52
@Josh-Cena Josh-Cena changed the title fix: make type-checking pass in Yarn PnP fix: make type-checking work in Yarn PnP May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants