Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove useless front matter #7518

Merged
merged 1 commit into from
May 28, 2022
Merged

docs: remove useless front matter #7518

merged 1 commit into from
May 28, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Reduce the use of front matter in favor of the defaults.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label May 28, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 28, 2022 10:52
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 28, 2022
@netlify
Copy link

netlify bot commented May 28, 2022 •
edited
Loading

✅ [V2]

Name Link
🔨 Latest commit 5c5f582
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/629200d458074d00080d3136
😎 Deploy Preview https://deploy-preview-7518--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 28, 2022 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 74 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 89 🟢 99 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena merged commit ab566ec into main May 28, 2022
@Josh-Cena Josh-Cena deleted the jc/refactor-docs branch May 28, 2022 11:07
boot-190 added a commit to boot-190/docusaurus that referenced this pull request Oct 29, 2022
@boot-190
Revert "docs: remove useless front matter (facebook#7518)"
71705d4 
This reverts commit ab566ec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @facebook-github-bot