Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): always treat error boundary fallback as a callback #7492

Merged
merged 4 commits into from
May 26, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented May 25, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Re-do #7368, after @slorber pointed out about performance issues.

The problem still stands: we needs to be clear whether the prop is a callback to be called, or a component to be rendered with JSX. We cannot have a mix of both.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label May 25, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 25, 2022 10:54
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 25, 2022
@Josh-Cena Josh-Cena force-pushed the jc/correct-error-boundary branch from 3ecd175 to 2ad6f46 Compare May 25, 2022 11:01
@netlify
Copy link

netlify bot commented May 25, 2022

[V2]

Name Link
🔨 Latest commit 3ecd175
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628e0ae1613548000ab52d49
😎 Deploy Preview https://deploy-preview-7492--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 25, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 84 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 85 🟢 99 🟢 100 🟢 100 🟢 90 Report

@netlify
Copy link

netlify bot commented May 25, 2022

[V2]

Name Link
🔨 Latest commit 3b96739
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628f58c966f215000b86da04
😎 Deploy Preview https://deploy-preview-7492--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 25, 2022

Size Change: +98 B (0%)

Total Size: 796 kB

Filename Size Change
website/build/assets/js/main.********.js 598 kB +98 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 106 kB
website/build/index.html 38.9 kB

compressed-size-action

@slorber slorber merged commit 9cf2bf1 into main May 26, 2022
@slorber slorber deleted the jc/correct-error-boundary branch May 26, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants