Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix ALL type errors in tests #7487

Merged
merged 1 commit into from
May 25, 2022
Merged

test: fix ALL type errors in tests #7487

merged 1 commit into from
May 25, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Wave 2 of #7486!

Mostly ugly casts, but we are at least free of red squiggly lines.

Better type infrastructure to come. (Especially with TS 4.7 released today; migration scheduled this weekend.)

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 25, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 25, 2022 05:38
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 25, 2022
@netlify
Copy link

netlify bot commented May 25, 2022

[V2]

Name Link
🔨 Latest commit 1854f52
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628dc26dcbd3250008b77018
😎 Deploy Preview https://deploy-preview-7487--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 25, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 71 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 87 🟢 99 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena force-pushed the jc/fix-type-error branch from c66aa2c to 1854f52 Compare May 25, 2022 05:45
@github-actions
Copy link

Size Change: 0 B

Total Size: 796 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 598 kB
website/build/index.html 38.9 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit d50fe3b into main May 25, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-type-error branch May 25, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants