refactor: make entire project typecheck with root tsconfig #7466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Again, using type-aware linting requires the root tsconfig to include all files (else we would need to create a TS Program for every package, which absolutely OOMs). However, the website folder uses a different tsconfig that doesn't extend the root. In this case, I've separated the website project out so it's type-checked alone, unaffected by the root.
Test Plan
The
__tests__
files still don't typecheck. However, now when you exclude them from the root tsconfig, there aren't any type errors when you runyarn tsc
at the root, only a few reports aboutexport =
, because in this single-run tsc,module
is set toesnext
.Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs