Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #7463

Merged
merged 3 commits into from
May 27, 2022
Merged

chore: upgrade dependencies #7463

merged 3 commits into from
May 27, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

See related discussion in #7455. Should we even go straight to Node 16?

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. label May 22, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 22, 2022 03:02
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 22, 2022
@netlify
Copy link

netlify bot commented May 22, 2022

[V2]

Name Link
🔨 Latest commit 2ef8975
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6290c5d98af4570008c7484c
😎 Deploy Preview https://deploy-preview-7463--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 22, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 93 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟢 91 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented May 22, 2022

Size Change: +48 B (0%)

Total Size: 796 kB

Filename Size Change
website/build/assets/js/main.********.js 599 kB +48 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 106 kB
website/build/index.html 38.9 kB

compressed-size-action

@Josh-Cena Josh-Cena changed the title chore: upgrade a few loaders, require Node 14.15 chore: upgrade Webpack plugins/loaders, require Node 14.15 May 22, 2022
@slorber
Copy link
Collaborator

slorber commented May 25, 2022

Should we even go straight to Node 16?

As discussed in the other RFC issue (#7455): 👍

I'd rather do this in another PR with only the Node.js bump:

  • Require Node 16.0
  • Add explicit 16.0 in GitHub Action test matrix (we currently don't test for the exact minimum version, but probably should).

['16.0', '16', '18'] matrix should be fine. If 16.0 does not work let's use another minor then?

@Josh-Cena
Copy link
Collaborator Author

Yes, 14.15 is required for this merge, but we can do 16 in another PR, that's the plan, right?

@slorber
Copy link
Collaborator

slorber commented May 25, 2022

My thought was to merge v16 now and then this PR (smaller, not bumping any Node.js version), but if you want to do the other way, no problem 😄

@Josh-Cena
Copy link
Collaborator Author

Ah, let's do it the other way round, then. No problem!

@Josh-Cena Josh-Cena mentioned this pull request May 26, 2022
3 tasks
@Josh-Cena Josh-Cena added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: dependencies Pull requests that update a dependency file and removed pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels May 26, 2022
@Josh-Cena Josh-Cena changed the title chore: upgrade Webpack plugins/loaders, require Node 14.15 chore: upgrade Webpack plugins/loaders May 26, 2022
@Josh-Cena Josh-Cena force-pushed the jc/upgrade-more-deps branch from 7f4ed1d to bd65d27 Compare May 26, 2022 09:52
@Josh-Cena Josh-Cena changed the title chore: upgrade Webpack plugins/loaders chore: upgrade dependencies May 26, 2022
@Josh-Cena
Copy link
Collaborator Author

Josh-Cena commented May 26, 2022

Going to upgrade other minor dependencies in the batch as well, since this no longer depends on a Node version bump

@Josh-Cena
Copy link
Collaborator Author

Blocked on #7422 so we can upgrade babel-plugin-dynamic-import-node (although the plan is to eventually remove it)

@Josh-Cena Josh-Cena force-pushed the jc/upgrade-more-deps branch from 9de7b0c to 2ef8975 Compare May 27, 2022 12:36
@Josh-Cena Josh-Cena merged commit 9398bb2 into main May 27, 2022
@Josh-Cena Josh-Cena deleted the jc/upgrade-more-deps branch May 27, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants