Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use TS project references instead of running tsc multiple times #7437

Merged
merged 6 commits into from
May 17, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

We're finally doing it the right way™

Using a single tsconfig.json means the editor is able to provide the right hints since the root tsconfig.json controls everything. It also means faster type-checking, and better integration with external tools (that are unaware of our custom tsconfig files).

Test Plan

I've checked the build output and made sure the output is still correct.

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label May 17, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 17, 2022 06:21
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 17, 2022
@netlify
Copy link

netlify bot commented May 17, 2022

[V2]

Name Link
🔨 Latest commit 4277618
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62834803d0e81a00080db621
😎 Deploy Preview https://deploy-preview-7437--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 17, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 70 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 89 🟢 99 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena force-pushed the jc/project-references branch from 7cc472a to f48068e Compare May 17, 2022 06:34
@github-actions
Copy link

Size Change: -11 kB (-1%)

Total Size: 796 kB

Filename Size Change
website/build/assets/js/main.********.js 599 kB -11 kB (-2%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 106 kB
website/build/index.html 38.9 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 7613ecb into main May 17, 2022
@Josh-Cena Josh-Cena deleted the jc/project-references branch May 17, 2022 07:21
@slorber
Copy link
Collaborator

slorber commented May 25, 2022

great 👍 didn't know about those refs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants