Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): consistently apply the right active class name for all navbar items #7430

Merged
merged 3 commits into from
May 25, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented May 16, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Inspired by #7404, I realized we are not apply the right class name for the locale dropdown. This PR fixes it by avoiding code duplication.

Test Plan

Test links

Deploy preview:

image

The locale link is now properly highlighted

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label May 16, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 16, 2022 08:52
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 16, 2022
@netlify
Copy link

netlify bot commented May 16, 2022

[V2]

Name Link
🔨 Latest commit 273f35b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628cd24255748800081bf015
😎 Deploy Preview https://deploy-preview-7430--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 16, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 84 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 87 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented May 16, 2022

Size Change: -192 B (0%)

Total Size: 796 kB

Filename Size Change
website/build/assets/js/main.********.js 598 kB -192 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 106 kB
website/build/index.html 38.9 kB

compressed-size-action

@Josh-Cena Josh-Cena force-pushed the jc/refactor-navbar branch from 611500e to 91d3b93 Compare May 16, 2022 09:29
@Josh-Cena Josh-Cena force-pushed the jc/refactor-navbar branch from 91d3b93 to 273f35b Compare May 24, 2022 12:40
@slorber
Copy link
Collaborator

slorber commented May 25, 2022

👍 looks like it works fine and happy to remove this utils file even if it duplicates a bit

@slorber slorber merged commit f609aca into main May 25, 2022
@slorber slorber deleted the jc/refactor-navbar branch May 25, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants