Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pwa): migrate client modules to TS #7421

Merged
merged 1 commit into from
May 15, 2022
Merged

refactor(pwa): migrate client modules to TS #7421

merged 1 commit into from
May 15, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

#5817

No code changes; only fixed a few little bugs

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label May 15, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 15, 2022 04:30
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 15, 2022
@github-actions
Copy link

Size Change: -28 B (0%)

Total Size: 812 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 52.3 kB 0 B
website/build/assets/css/styles.********.css 106 kB 0 B
website/build/assets/js/main.********.js 615 kB -28 B (0%)
website/build/index.html 38.9 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented May 15, 2022

[V2]

Name Link
🔨 Latest commit f46b772
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628081e70a0d0b000940fd41
😎 Deploy Preview https://deploy-preview-7421--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 52 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 79 🟢 99 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena merged commit 7ea59b4 into main May 15, 2022
@Josh-Cena Josh-Cena deleted the jc/ts-pwa branch May 15, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants