Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Massoud Maboudi's portfolio to showcase #7412

Merged

Conversation

massoudmaboudi
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Another RTL website from @massoudmaboudi 😁

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#7406

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 13, 2022
@netlify
Copy link

netlify bot commented May 13, 2022

[V2]

Name Link
🔨 Latest commit 337f41f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/628dec37ecd0600007a7041f
😎 Deploy Preview https://deploy-preview-7412--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 13, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 66 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 73 🟢 99 🟢 100 🟢 100 🟢 90 Report

@massoudmaboudi
Copy link
Contributor Author

any update on this PR?

@Josh-Cena
Copy link
Collaborator

@massoudmaboudi Seems you didn't do a clean merge?

Also, I'd like to get @slorber's confirmation that we'd like this in favorites (I'd like it to), but he's currently on holiday.

@massoudmaboudi
Copy link
Contributor Author

@massoudmaboudi Seems you didn't do a clean merge?

Also, I'd like to get @slorber's confirmation that we'd like this in favorites (I'd like it to), but he's currently on holiday.

@Josh-Cena
I did, but things keep changing so I have to update it to resolve the conflicts.
Thanks

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented May 23, 2022

I did, but things keep changing so I have to update it to resolve the conflicts.

Your branch is not merged—look at the diff, you still have a diverging branch. That's why you have so many conflicts.

@Josh-Cena Josh-Cena force-pushed the massoudmaboudi/iammassoud-add-showcase branch from 9aa3f3b to 0858c84 Compare May 23, 2022 03:08
@Josh-Cena
Copy link
Collaborator

OK, I've done a clean merge for you.

@slorber
Copy link
Collaborator

slorber commented May 25, 2022

Thanks 👍

I'm not really willing to add this one to favorites.

Your 2 RTL sites are not bad, but are not really as good as other favorite sites in terms of design and customization.
The reason your other site is in favorite is that it's the only RTL site we have in our showcase currently.

BTW your RTL favorite site is likely to be replaced one day by another better/larger site that also uses RTL.

Don't take this personally and it doesn't mean your sites are bad: we'd like to keep favorite sites count low (otherwise it doesn't mean anything anymore), maybe like 15-20 sites max, and some sites may lose their favorite label over time

If we have to keep only 1 RTL site in favorites, I'd rather keep your other site as at least it has some docs and more content, unlike this new one

website/src/data/users.tsx Outdated Show resolved Hide resolved
@massoudmaboudi
Copy link
Contributor Author

Thanks 👍

I'm not really willing to add this one to favorites.

Your 2 RTL sites are not bad, but are not really as good as other favorite sites in terms of design and customization. The reason your other site is in favorite is that it's the only RTL site we have in our showcase currently.

BTW your RTL favorite site is likely to be replaced one day by another better/larger site that also uses RTL.

Don't take this personally and it doesn't mean your sites are bad: we'd like to keep favorite sites count low (otherwise it doesn't mean anything anymore), maybe like 15-20 sites max, and some sites may lose their favorite label over time

If we have to keep only 1 RTL site in favorites, I'd rather keep your other site as at least it has some docs and more content, unlike this new one

It's nothing about personal.

If there are other RTL websites then I would love to learn from them also so please don't hesitate to replace them.
But today I've changed my website theme and design completely. So it has nested pages and documents.

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants