-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Massoud Maboudi's portfolio to showcase #7412
docs: add Massoud Maboudi's portfolio to showcase #7412
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
any update on this PR? |
@massoudmaboudi Seems you didn't do a clean merge? Also, I'd like to get @slorber's confirmation that we'd like this in favorites (I'd like it to), but he's currently on holiday. |
@Josh-Cena |
Your branch is not merged—look at the diff, you still have a diverging branch. That's why you have so many conflicts. |
9aa3f3b
to
0858c84
Compare
OK, I've done a clean merge for you. |
Thanks 👍 I'm not really willing to add this one to favorites. Your 2 RTL sites are not bad, but are not really as good as other favorite sites in terms of design and customization. BTW your RTL favorite site is likely to be replaced one day by another better/larger site that also uses RTL. Don't take this personally and it doesn't mean your sites are bad: we'd like to keep favorite sites count low (otherwise it doesn't mean anything anymore), maybe like 15-20 sites max, and some sites may lose their favorite label over time If we have to keep only 1 RTL site in favorites, I'd rather keep your other site as at least it has some docs and more content, unlike this new one |
It's nothing about personal. If there are other RTL websites then I would love to learn from them also so please don't hesitate to replace them. |
Pre-flight checklist
Motivation
Another RTL website from @massoudmaboudi 😁
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
#7406