Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): properly code-split NotFound page #7405

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented May 12, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

While debugging #7238, I noticed our 404 page is not code-splitted properly. Although I think it's still does its work, let's make it more correct.

This still does not fix that issue though, I will need to look deeper into it.

Test Plan

Test links

Deploy preview: https://deploy-preview-7405--docusaurus-2.netlify.app/foo

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 12, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 12, 2022 07:48
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 12, 2022
@Josh-Cena Josh-Cena added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. CLA Signed Signed Facebook CLA and removed CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. labels May 12, 2022
@netlify
Copy link

netlify bot commented May 12, 2022

[V2]

Name Link
🔨 Latest commit d5eaee1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627cbbc72bbfd3000858593a
😎 Deploy Preview https://deploy-preview-7405--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 86 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 87 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: +57 B (0%)

Total Size: 812 kB

Filename Size Change
website/build/assets/js/main.********.js 615 kB +57 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 106 kB
website/build/index.html 38.9 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit d2ca4a1 into main May 12, 2022
@Josh-Cena Josh-Cena deleted the jc/refactor-404 branch May 12, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants