Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(theme-translations): complete Farsi translations #7400

Merged
merged 1 commit into from
May 12, 2022
Merged

chore(theme-translations): complete Farsi translations #7400

merged 1 commit into from
May 12, 2022

Conversation

massoudmaboudi
Copy link
Contributor

@massoudmaboudi massoudmaboudi commented May 11, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

To add missing Farsi translations and improve the previous ones

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 11, 2022
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label May 11, 2022
@Josh-Cena Josh-Cena changed the title refactor: improved and fixed farsi translations chore(theme-translations): complete Farsi translations May 11, 2022
@netlify
Copy link

netlify bot commented May 11, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 79fb947
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627bd985ed45f40009062f77
😎 Deploy Preview https://deploy-preview-7400--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 62 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 78 🟢 99 🟢 100 🟢 100 🟢 90 Report

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks as always!

@Josh-Cena Josh-Cena merged commit bcf3813 into facebook:main May 12, 2022
@massoudmaboudi massoudmaboudi deleted the massoudmaboudi/improve-farsi-translation branch May 12, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants