Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use "pr:" prefix for changelog labels; elaborate on labeling process #7394

Merged
merged 1 commit into from
May 11, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The name "tag:" is a bit confusing, because "tag" also refers to the git tags for each release. Using "pr:" eliminates the ambiguity.

I've also elaborated in the release docs about how labeling should happen.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 11, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 11, 2022 04:53
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 11, 2022
@netlify
Copy link

netlify bot commented May 11, 2022

[V2]

Name Link
🔨 Latest commit 17b5dc8
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627b413d567c9600091b7944
😎 Deploy Preview https://deploy-preview-7394--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 67 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 85 🟢 99 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena merged commit 8973727 into main May 11, 2022
@Josh-Cena Josh-Cena deleted the jc/tag branch May 11, 2022 05:03
@slorber
Copy link
Collaborator

slorber commented May 25, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants