Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-docs): restore functionality when a category only has index page #7385

Merged
merged 2 commits into from
May 10, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented May 10, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fix #7348
Fix #7358

Test Plan

I added a few unit tests. These tests were malbehaving prior to the code changes.

I also migrated logger and canary docs to use this pattern so we can dogfood.

Test links

Deploy preview:

Related issues/PRs

Regression introduced by #6457

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label May 10, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 10, 2022 06:22
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 10, 2022
@netlify
Copy link

netlify bot commented May 10, 2022

[V2]

Name Link
🔨 Latest commit 09d2206
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627a06f3e2ada80009da04dc
😎 Deploy Preview https://deploy-preview-7385--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 10, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 66 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 85 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: +114 B (0%)

Total Size: 811 kB

Filename Size Change
website/.docusaurus/globalData.json 52.3 kB +50 B (0%)
website/build/assets/js/main.********.js 615 kB +64 B (0%)
ℹ️ View Unchanged
Filename Size
website/build/assets/css/styles.********.css 105 kB
website/build/index.html 38.8 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
2 participants