Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Piano Analytics to showcase #7381

Merged
merged 2 commits into from
May 11, 2022

Conversation

BenDz
Copy link
Contributor

@BenDz BenDz commented May 9, 2022

Pre-flight checklist

Motivation

Request for adding Piano Analytics to showcase.

Test Plan

N/A

Test links

N/A

Related issues/PRs

N/A

@BenDz BenDz requested review from slorber, lex111 and Josh-Cena as code owners May 9, 2022 13:53
@facebook-github-bot
Copy link
Contributor

Hi @BenDz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented May 9, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 0a8fe47
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627a3aaf7e3c620009a3dc2c
😎 Deploy Preview https://deploy-preview-7381--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 9, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 69 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 87 🟢 99 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 9, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented May 9, 2022

Thanks!

This site will almost qualify in our favorites section, but it does not have sufficient contrast ratio, so it's poor accessibility-wise. Would you mind to tweak the palette a bit, and we can consider if we can add this to favorites before merging?

@Josh-Cena Josh-Cena added the status: don't merge yet This PR is completed, but we are still waiting for other things to be ready. label May 10, 2022
@BenDz
Copy link
Contributor Author

BenDz commented May 10, 2022

Thanks!

This site will almost qualify in our favorites section, but it does not have sufficient contrast ratio, so it's poor accessibility-wise. Would you mind to tweak the palette a bit, and we can consider if we can add this to favorites before merging?

Thanks for your positive feedback!
I shifted a bit the contrast, and should be AAA compliant now. Let me know should there be any other improvements to make.

@Josh-Cena
Copy link
Collaborator

The same would go for the sidebar labels.

@BenDz
Copy link
Contributor Author

BenDz commented May 10, 2022

My bad, I just updated it too.

@Josh-Cena
Copy link
Collaborator

Non-critical, but I'd like to point out that your font sizes are a bit too small. Even weirder is that the right TOC seems to have the largest font?

@Josh-Cena Josh-Cena added pr: showcase and removed status: don't merge yet This PR is completed, but we are still waiting for other things to be ready. labels May 10, 2022
@Josh-Cena
Copy link
Collaborator

@BenDz I think it's ready. Do you want to enlarge the font a bit and we can re-take a screenshot?

@BenDz
Copy link
Contributor Author

BenDz commented May 11, 2022

I just enlarged the font, let me know if this is better to you.
Thanks!

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks really great! You deserve to be in favorites :)

@Josh-Cena Josh-Cena merged commit cd0aff4 into facebook:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants