Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): fix code block Crowdin issue #7345

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 5, 2022

Fix site can't deploy because Crowdin download badly formatted markdown with bad code block backticks

https://app.netlify.com/sites/docusaurus-2/deploys/6273b760dc5aaf0008442f3b

This leads to Docusaurus thinking some links are inside a code block, leading to broken links (unresolved md paths)

https://app.netlify.com/sites/docusaurus-2/deploys/6273b760dc5aaf0008442f3b

Also prod website for FR:

CleanShot 2022-05-05 at 15 19 33@2x

https://docusaurus.io/fr/docs/next/installation


Solution is to apply mdx-code-block only around JSX tags so that it doesn't mess up with Crowdin

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 5, 2022
@slorber slorber requested review from lex111 and Josh-Cena as code owners May 5, 2022 13:20
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 5, 2022
@netlify
Copy link

netlify bot commented May 5, 2022

[V2]

Name Link
🔨 Latest commit 2a60dec
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6273cf04dc5aaf000847888d
😎 Deploy Preview https://deploy-preview-7345--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 5, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 65 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 83 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented May 5, 2022

Size Change: 0 B

Total Size: 807 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 51.4 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 612 kB
website/build/index.html 38.8 kB

compressed-size-action

@slorber slorber merged commit c892492 into main May 5, 2022
@slorber slorber deleted the slorber/fix-crowdin-doc branch May 5, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants