Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: move lighthouse message formatter to admin folder, refactor #7338

Merged
merged 1 commit into from
May 5, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Moved it to admin/scripts, so that it can be linted.
Refactored it to use TypeScript + ESM.
Should make it more DRY and less likely to break when API changes?

@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 5, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 5, 2022 06:38
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 5, 2022
@netlify
Copy link

netlify bot commented May 5, 2022

[V2]

Name Link
🔨 Latest commit 009d2ae
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627370f8979db00008a9629d
😎 Deploy Preview https://deploy-preview-7338--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 5, 2022

⚡️ Lighthouse report for the changes in this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 60 🟢 100 🟢 100 🟢 100 🟢 90 View report
/docs/installation 🟠 85 🟢 96 🟢 100 🟢 100 🟢 90 View report

@Josh-Cena Josh-Cena merged commit eea27aa into main May 5, 2022
@Josh-Cena Josh-Cena deleted the jc/refactor-lighthouse branch May 5, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants