Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix site deployment Crowdin issue #7326

Merged
merged 1 commit into from
May 4, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 4, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The site can't deploy due to MDX and too many code block backticks, messing up with Crowdin translations

Not sure it's the best way to fix it but it works better at least 🤷‍♂️

Test Plan

local + preview

CleanShot 2022-05-04 at 17 39 14@2x

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#7307

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 4, 2022
@slorber slorber requested review from lex111 and Josh-Cena as code owners May 4, 2022 15:39
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 4, 2022
@netlify
Copy link

netlify bot commented May 4, 2022

[V2]

Name Link
🔨 Latest commit 4768645
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62729e43b34548000826f03e
😎 Deploy Preview https://deploy-preview-7326--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@slorber slorber merged commit c31d076 into main May 4, 2022
@github-actions
Copy link

github-actions bot commented May 4, 2022

⚡️ Lighthouse report for the changes in this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 55 🟢 100 🟢 100 🟢 100 🟢 90 View report
/docs/installation 🟠 84 🟢 96 🟢 100 🟢 100 🟢 90 View report

@slorber slorber deleted the slorber/fix-website-deploy-i18n branch May 4, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants