Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: run Lighthouse CI without assertions #7308

Merged
merged 1 commit into from
May 4, 2022
Merged

misc: run Lighthouse CI without assertions #7308

merged 1 commit into from
May 4, 2022

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 4, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This should not prevent the creating of a comment with the report in case of insufficient score (see https://github.com/facebook/docusaurus/runs/6289742244?check_suite_focus=true)

@lex111 lex111 requested review from slorber and Josh-Cena as code owners May 4, 2022 12:43
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 4, 2022
@netlify
Copy link

netlify bot commented May 4, 2022

[V2]

Name Link
🔨 Latest commit 72fee14
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627275048ea72d000a429b65
😎 Deploy Preview https://deploy-preview-7308--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 4, 2022
@lex111 lex111 merged commit 344f795 into main May 4, 2022
@lex111 lex111 deleted the lex111-patch-1 branch May 4, 2022 12:57
@slorber
Copy link
Collaborator

slorber commented May 4, 2022

just wondering if it's possible to fail the CI check and yet publish the comment?

It's a practice to turn assertion to 100% score and disable some rules, ensuring that we never regress from that point

@lex111
Copy link
Contributor Author

lex111 commented May 4, 2022

just wondering if it's possible to fail the CI check and yet publish the comment?

Apparently yes, I was too hasty with this deletion, since I should better change error to warn, and CI check was passed without fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants