Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): remove breadcrumb items without href from microdata #7304

Merged
merged 1 commit into from
May 4, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented May 4, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This has caused too much confusion, both on Discord and on the issue tracker (#7303, #7241). Even when I tend to think it's working as intended, let's remove it from the default theme to conform to the one and only truth™ in search engines.

Test Plan

Tested on rich results; it's valid now.

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label May 4, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 4, 2022 07:43
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 4, 2022
@netlify
Copy link

netlify bot commented May 4, 2022

[V2]

Name Link
🔨 Latest commit 58395a1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62728d943609f5000925f1a2
😎 Deploy Preview https://deploy-preview-7304--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 4, 2022

⚡️ Lighthouse report for the changes in this PR

URL Performance Accessibility Best Practices SEO PWA Report
https://deploy-preview-7304--docusaurus-2.netlify.app/ 🟠 55 🟢 100 🟢 92 🟢 100 🟢 90 View report
https://deploy-preview-7304--docusaurus-2.netlify.app/docs/ 🟠 61 🟢 94 🟢 92 🟢 90 🟢 90 View report

@github-actions
Copy link

github-actions bot commented May 4, 2022

Size Change: 0 B

Total Size: 804 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 50.7 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 610 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena Josh-Cena force-pushed the jc/fix-breadcrumb branch from b7bd8aa to 58395a1 Compare May 4, 2022 14:28
@slorber
Copy link
Collaborator

slorber commented May 4, 2022

🤷‍♂️ google seems to like this better 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants