-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: check doc page by Lighthouse CI #7300
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7300--docusaurus-2.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check both?
The landing page's performance is still important, like FCP
Perhaps need to merge this change so that the config for CI is updated? |
Theoretically, the action should be using the config on this branch, especially since this is not in a fork. At least that's how I tested my config changes. My main worry is how audits on multiple URLs will be formatted, so I'd need to see at least what the output looks like. |
@lex111 From our |
I don't quite understand you, it will be for each of the checked pages by a separate table? |
I'm suggesting it to be | Category | Landing page score | Doc page score |
| --- | --- | --- |
| Performance | 🟠 57 | 🟠 57 |
| Accessibility | 🟢 100 | 🟢 100 |
| Best practices | 🟢 92 | 🟢 92 |
| SEO | 🟢 100 | 🟢 100 |
| PWA | 🟢 90 | 🟢 90 | So instead of using |
I have another idea how visualize data that should work, but it is problematic to test these changes. |
Yeah, I can understand. Do you want to merge this so we can test it? |
Yes, let's check it out in action. |
Pre-flight checklist
Motivation
Since the doc page represents the main functionality of Docusaurus, Lighthouse should check it instead of the landing page. For example, the a11y error with the home page in the breadcrumbs could have been detected earlier.