refactor: use export = syntax for Node utility packages #7295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
We previously had some hack around
module.exports
to support importing these packages in both ESM and CJS, becauseexport default
will be compiled tomodule.exports.default =
, which will work in neither ESM nor CJS (only in TypeScript, where it knows how to handledefault
). We didn't useexport =
because Babel doesn't like it unless we use another plugin. This turns out to be no longer necessary now, because we use SWC instead of Babel, which supportsexport =
OOTB, without bringing some extra plugins.Test Plan
Everything still works