Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(create): add i18n config in init template #7290

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented May 3, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I've noticed a lot of non-English sites not changing their language correctly—this is bad for both SEO and accessibility. Putting it in the init template should allow better visibility.

@Josh-Cena Josh-Cena added pr: polish This PR adds a very minor behavior improvement that users will enjoy. status: awaiting review This PR is ready for review, will be merged after maintainers' approval labels May 3, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 3, 2022 04:38
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 3, 2022
@netlify
Copy link

netlify bot commented May 3, 2022

[V2]

Name Link
🔨 Latest commit 9de672f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6270b1b65990bd0009d536d8
😎 Deploy Preview https://deploy-preview-7290--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 3, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 63
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7290--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented May 3, 2022

Size Change: 0 B

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 50.5 kB
website/build/assets/css/styles.********.css 107 kB
website/build/assets/js/main.********.js 609 kB
website/build/index.html 38.8 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented May 4, 2022

👍 can be useful

@slorber slorber merged commit 35b0f0d into main May 4, 2022
@slorber slorber deleted the jc/template-i18n branch May 4, 2022 14:09
@Josh-Cena Josh-Cena removed the status: awaiting review This PR is ready for review, will be merged after maintainers' approval label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants