Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(theme-classic): refactor TOC-related theme components #7270

Merged
merged 2 commits into from
Apr 29, 2022
Merged

refactor(theme-classic): refactor TOC-related theme components #7270

merged 2 commits into from
Apr 29, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Apr 29, 2022

Motivation

  • Extract TOCItemTree
  • Extract TOCCollapsible CollapseButton
  • Better CSS split

Test Plan

preview exactly as before

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 29, 2022
@netlify
Copy link

netlify bot commented Apr 29, 2022

✅ [V2]

Name Link
🔨 Latest commit 4f79ac4
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/626c1d28f95907000b4dc243
😎 Deploy Preview https://deploy-preview-7270--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Size Change: +8 B (0%)

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 50.7 kB 0 B
website/build/assets/css/styles.********.css 107 kB +8 B (0%)
website/build/assets/js/main.********.js 609 kB 0 B
website/build/index.html 38.8 kB 0 B

compressed-size-action

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Apr 29, 2022
@slorber slorber merged commit e053f39 into main Apr 29, 2022
@slorber slorber deleted the slorber/refactor-tocItems branch April 29, 2022 17:32
@Josh-Cena Josh-Cena mentioned this pull request Apr 30, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slorber @facebook-github-bot