Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract useSkipToContent() #7269

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Apr 29, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

move useSkipToContent() technical code to theme-common

Test Plan

no change

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Apr 29, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 29, 2022
@netlify
Copy link

netlify bot commented Apr 29, 2022

[V2]

Name Link
🔨 Latest commit a7254ec
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/626c17a8f87d970009b3af28
😎 Deploy Preview https://deploy-preview-7269--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 65
🟢 Accessibility 100
🟠 Best practices 83
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7269--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +129 B (0%)

Total Size: 806 kB

Filename Size Change
website/build/assets/js/main.********.js 609 kB +129 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 50.7 kB
website/build/assets/css/styles.********.css 107 kB
website/build/index.html 38.8 kB

compressed-size-action

@netlify
Copy link

netlify bot commented Apr 29, 2022

[V2]

Name Link
🔨 Latest commit 9c63c4f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/626c1829e8420800089a123e
😎 Deploy Preview https://deploy-preview-7269--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@slorber slorber merged commit 3bef882 into main Apr 29, 2022
@slorber slorber deleted the slorber/extract-skipToContent branch April 29, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants