-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: add links section to PR template #7266
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this:
## Test plan
Deploy preview: https://deploy-preview-___--docusaurus-2.netlify.app/
## Related issues/PRs
<!-- ... -->
Also, I'd suggest use fewer emojis...
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7266--docusaurus-2.netlify.app/ |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
Size Change: 0 B Total Size: 803 kB ℹ️ View Unchanged
|
Also, a problem I personally have with deploy preview links is that they are only available after you have sent the PR, so you almost always send the PR with that left blank. Quite inconvenient. |
I don't know, looks fine to me, and drive user attention to some text that would otherwise not be read
will add a mention for that |
We can also have a pre-flight checklist, if you want it to be more visible. Either is fine for me |
open to any suggestion, as long as it's visible enough :) feel free to edit |
faaf2a4
to
3d025ad
Compare
@slorber Made some edits. WDYT? |
seems good enough 👍 |
This is really helpful in PR to have links to:
This saves me a ton of time, and when it's not done, I generally do this even just for myself.
Sometimes it takes a long time to read diff, find relevant doc changes, infer URLs mentally and navigate to relevant doc pages, and a doc page may require multiple reviews before merging so it's really a time saver to include links ahead of time.