Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: wrap code block demos in mdx-code-block #7262

Merged
merged 1 commit into from
Apr 29, 2022
Merged

docs: wrap code block demos in mdx-code-block #7262

merged 1 commit into from
Apr 29, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Try to fix #7261

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 29, 2022
slorber
slorber approved these changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 could help

@netlify
Copy link

netlify bot commented Apr 29, 2022

✅ [V2]

Name Link
🔨 Latest commit 1890bc2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/626baa10df108700083e4140
😎 Deploy Preview https://deploy-preview-7262--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟢 Accessibility 100
🟠 Best practices 83
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7262--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena merged commit 0102c2e into main Apr 29, 2022
@Josh-Cena Josh-Cena deleted the jc/mdx-code-block branch April 29, 2022 09:09
@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber slorber approved these changes

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in code-blocks zh-CN docs
3 participants
@Josh-Cena @slorber @facebook-github-bot