docs: add documentation about pluralization #7236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
the
pr: documentation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7236--docusaurus-2.netlify.app/ |
slorber
reviewed
Apr 27, 2022
Comment on lines
+285
to
+291
| const message = selectMessage( | ||
| items.length, | ||
| translate( | ||
| {message: 'One item|{count} items'}, | ||
| {count: items.length}, | ||
| ), | ||
| ); |
There was a problem hiding this comment.
hmmm, this is what we have in our code but that looks a bit weird to me, as we translate everything and only then select
At the same time we have to pass a static message config to translate() otherwise it wouldn't be extracted
Maybe we'd need like react-intl a new method like defineMessage() that permits static extraction but without directly translating 🤷♂️
Not a big deal, we can keep it this way for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are probably very few people that fully understand how the plural forms work. Let's write some basic explanation.
Have you read the Contributing Guidelines on pull requests?
Yes