Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-docs): make category index text translatable #7233

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Reported in #4542 (comment)

This PR enforces single source of truth for the docs content. We no longer derive some content fields from other content fields, so that we don't accidentally forget some translations.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tested locally with yarn write-translations -l zh-CN and translating some descriptions.

image

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Apr 23, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 23, 2022
@netlify
Copy link

netlify bot commented Apr 23, 2022

[V2]

Name Link
🔨 Latest commit 0bc33e1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6263c4d7022a6e000838ab69
😎 Deploy Preview https://deploy-preview-7233--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 66
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7233--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 803 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 50.1 kB
website/build/assets/css/styles.********.css 107 kB
website/build/assets/js/main.********.js 607 kB
website/build/index.html 38.8 kB

compressed-size-action

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM and ready to merge (I can't 😅 )

@Josh-Cena
Copy link
Collaborator Author

Aye, no problem :P

@Josh-Cena Josh-Cena merged commit 10a5ebe into main Apr 27, 2022
@Josh-Cena Josh-Cena deleted the jc/translate-category-indices branch April 27, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants