Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): always show error stack to unhandled rejection #7218

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Currently, all build-time errors don't show proper stack traces because we only log the error itself, which serializes to the message. We should log the full stack instead.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Throw an error from lib/commands/build.js.

Before:

image

After:

image

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 21, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 21, 2022
@netlify
Copy link

netlify bot commented Apr 21, 2022

[V2]

Name Link
🔨 Latest commit 9f3d595
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6260e11ec0f2d70008cb1506
😎 Deploy Preview https://deploy-preview-7218--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 66
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7218--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 799 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 50 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 604 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 97f7b45 into main Apr 21, 2022
@Josh-Cena Josh-Cena deleted the jc/err-stack branch April 21, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants