Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve IconHome icon #7215

Merged
merged 3 commits into from
Apr 20, 2022
Merged

refactor: improve IconHome icon #7215

merged 3 commits into from
Apr 20, 2022

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 20, 2022

Motivation

Slight optimization for new Home icon, as well as a slight increase in its size to better fit with font-size of text.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 20, 2022
@netlify
Copy link

netlify bot commented Apr 20, 2022

[V2]

Name Link
🔨 Latest commit ab5f9a0
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/626004337ee6680008dea89c
😎 Deploy Preview https://deploy-preview-7215--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 20, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 59
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7215--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Apr 20, 2022

Size Change: +4 B (0%)

Total Size: 799 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 50 kB 0 B
website/build/assets/css/styles.********.css 106 kB +4 B (0%)
website/build/assets/js/main.********.js 604 kB 0 B
website/build/index.html 38.8 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Apr 20, 2022

[V2]

Name Link
🔨 Latest commit d6e4be9
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/626004873b5e3600084e47c9
😎 Deploy Preview https://deploy-preview-7215--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 20, 2022

[V2]

Name Link
🔨 Latest commit ae472f5
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/626007398be422000853d000
😎 Deploy Preview https://deploy-preview-7215--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

width="24"
viewBox="0 0 24 24"
{...props}>
<path d="M0 0h24v24H0V0z" fill="none" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I vividly remember I removed this... Must have forgotten to push it, then

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Josh-Cena Josh-Cena merged commit 1ba5bf6 into main Apr 20, 2022
@Josh-Cena Josh-Cena deleted the lex111-patch-1 branch April 20, 2022 13:34
@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants