chore(theme-translations): complete Polish translations

[rev4324]

Motivation

Have you read the Contributing Guidelines on pull requests?

Test Plan

Related PRs

[facebook-github-bot]

Hi @rev4324!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[Josh-Cena]

@rev4324 There are some other files that can be translated as well. Could you take a look? (plugin-ideal-image and theme-search-algolia)

@Simek Could you help review this please?

[netlify]

✅ [V2]

Built without sensitive environment variables

Name	Link
🔨 Latest commit	199e4ac
🔍 Latest deploy log	https://app.netlify.com/sites/docusaurus-2/deploys/62613d79bc136b00087c9ac7
😎 Deploy Preview	https://deploy-preview-7214--docusaurus-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟠 Performance	52
🟢 Accessibility	100
🟢 Best practices	92
🟢 SEO	100
🟢 PWA	90

Lighthouse ran on https://deploy-preview-7214--docusaurus-2.netlify.app/

[Simek]

LGMT, thank you for the translation updates @rev4324! 👍

I can also help with filling remaining gaps in i18n files, if you don't want to continue working on the translation.

[Josh-Cena]

Let's see if @rev4324 wants to do it. If @rev4324 doesn't have the bandwidth until next Monday (provided they did sign the CLA in the meantime) I'll merge this and you can follow up. Much appreciated, for both of you guys!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[rev4324]

No problem, I'll look into translating the remaining sentences in other files soon. Glad I could help.

[Josh-Cena]

Thanks! There are a few missing in theme-common.json. Mind taking a look?

[Josh-Cena]

Thanks a lot @rev4324

@Simek We can merge once with a confirmation from you

[Simek]

Generally this look nice, I have suggested adding missing plural forms, Polish language uses three by default, and Docusausaurs supports it:

• https://github.com/facebook/docusaurus/blob/main/packages/docusaurus-theme-translations/locales/base/theme-search-algolia.json#L8

Additionally, I have suggested the alteration for the "image" translation, which suites the context a bit more, and it's more widely used on the web, ex. Google etc.

[Josh-Cena]

@Simek Out of plain curiosity:

>> new Intl.PluralRules("pl").resolvedOptions().pluralCategories
<< ['few', 'many', 'one', 'other']

(Docusaurus interprets multiple pluralizations in the order ['zero', 'one', 'two', 'few', 'many', 'other'].)

I wonder which ones your translations correspond to?

[Simek]

Oh, I see. I was wondering why there are two pipes in a row in some translations (||).

Polish forms are different for "one", "two-four", "five+" and I have used this order in the suggestions. I'm curious to what ranges few and many corresponds to. Depends on that we might want to alter the translations.

[Josh-Cena]

According to my tests, "few" is 2-4, and "many" is 5+. "other" seems to be non-integers, so it's irrelevant here. If we are already ordering the plurals in that order (one|few|many) it should be good!

[Josh-Cena]

@rev4324 Please take a look at the suggestions above ^^ I'll apply those changes and merge tomorrow if there are no further opinions.

[slorber]

If that helps: https://unicode-org.github.io/cldr-staging/charts/37/supplemental/language_plural_rules.html

[Simek]

Just FYI, the range section is a bit overcomplicated in there, generally the range end form is used for the whole range pluralization, which also can be seen in the most right column. In other words the form of start of the range doesn't matter in i18n context.

[rev4324]

Thanks for the suggestions, you're right about the "image" translation, your way fits better. Also, I didn't know about the distinction between "few" and "many", since the source that I edited had only one of these two forms.
I created a page in Polish after these changes and I didn't see any incorrect/missing translations now, so I think we're good.

[Josh-Cena]

Thanks a lot! @Simek @rev4324