Fix assets not found in Express server #720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #600
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Create an image file in
docs/assets/docusaurus.png
Paste this to
docs/getting-started-installation.md
content![docusaurus](/docs/assets/docusaurus.png)
Run server on windows
http://localhost:3000/docs/en/next/installation.html
Before this PR
After this PR
Explanation:
According to https://expressjs.com/en/starter/static-files.html
The function signature is:
Previous code
We should not use path.join on Express root argument. Express.js expect something like
/docs/assets/
as a root argument.path.join
in Unix systems work differently when in Windows work.Example:
In UNIX
/docs/assets
In Windows
\docs\assets