Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prefer fs.readJSON over readFile.then(JSON.parse) #7186

Merged
merged 2 commits into from
Apr 17, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Makes the code more semantic.

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Apr 17, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 17, 2022
@netlify
Copy link

netlify bot commented Apr 17, 2022

[V2]

Name Link
🔨 Latest commit c39411b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/625b9a7d655d30000875b204
😎 Deploy Preview https://deploy-preview-7186--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 17, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 55
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7186--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Apr 17, 2022

Size Change: 0 B

Total Size: 799 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 50 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 604 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 2000090 into main Apr 17, 2022
@Josh-Cena Josh-Cena deleted the jc/readjson branch April 17, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants