Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage #7181

Merged
merged 1 commit into from
Apr 16, 2022
Merged

test: improve test coverage #7181

merged 1 commit into from
Apr 16, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Recent code changes have decreased test coverage a bit; this adds the missing tests. We should really think about adding the coverage bot...

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 16, 2022
@netlify
Copy link

netlify bot commented Apr 16, 2022

[V2]

Name Link
🔨 Latest commit 46cb916
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/625a7cb57f630600098ea6ae
😎 Deploy Preview https://deploy-preview-7181--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 60
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7181--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 799 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 50 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 604 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit f219a2a into main Apr 16, 2022
@Josh-Cena Josh-Cena deleted the jc/test branch April 16, 2022 08:35
@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants