Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass pollOptions to webpack #7180

Merged
merged 7 commits into from
Apr 29, 2022
Merged

fix: pass pollOptions to webpack #7180

merged 7 commits into from
Apr 29, 2022

Conversation

JohnnyMcWeed
Copy link
Contributor

@JohnnyMcWeed JohnnyMcWeed commented Apr 15, 2022

Motivation

Poll is not working in Docker, see #6722

Have you read the [Contributing Guidelines on pull requests]

No.

Test Plan

Manually tested, as there are no test cases for the start command afaik.

Related PRs

This issue might be related to it: #6722

@facebook-github-bot
Copy link
Contributor

Hi @JohnnyMcWeed!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Josh-Cena Josh-Cena changed the title Bug fix fix: pass pollOptions to webpack Apr 15, 2022
@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Apr 15, 2022
@netlify
Copy link

netlify bot commented Apr 15, 2022

[V2]

Name Link
🔨 Latest commit b6c38af
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/626ba155451f7b5591ce8dec
😎 Deploy Preview https://deploy-preview-7180--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 15, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 60
🟢 Accessibility 100
🟠 Best practices 83
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7180--docusaurus-2.netlify.app/

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 15, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Willing to merge this after a few changes

packages/docusaurus/src/commands/start.ts Outdated Show resolved Hide resolved
packages/docusaurus/src/commands/start.ts Outdated Show resolved Hide resolved
packages/docusaurus/bin/docusaurus.mjs Outdated Show resolved Hide resolved
@slorber
Copy link
Collaborator

slorber commented Apr 27, 2022

LGTM 👍

@slorber slorber merged commit 7073cc3 into facebook:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants