-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(theme-classic): split CodeBlock #7175
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7175--docusaurus-2.netlify.app/ |
Size Change: 0 B Total Size: 799 kB ℹ️ View Unchanged
|
<CodeBlockContainer | ||
as="pre" | ||
tabIndex={0} | ||
className={clsx(styles.codeBlockStandalone, 'thin-scrollbar', className)}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this refactor I realized the ReactElement version doesn't accept title
. I tried a bit but because it's inside a pre
the font is different. Just a note that we may want to support that in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result looks the same
We should definitely allow that. I also realized we can't swizzle one of |
Motivation
Preliminary refactor before extracting new theme components meant to be swizzled
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Preview tests should be exactly as before