Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): admonition title: disable text-transform on inline code blocks #7173

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

chelproc
Copy link
Contributor

@chelproc chelproc commented Apr 14, 2022

Motivation

Currently text-transform: uppercase is set for .admonition h5. This makes all texts uppercased even when wrapped by <code />.

:::tip This is a `code`
:::

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

After changes are made, codes are no longer uppercased as shown in the screenshot below.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 14, 2022
@netlify
Copy link

netlify bot commented Apr 14, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 771301e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6258238d1419ce0008ae2ad5
😎 Deploy Preview https://deploy-preview-7173--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7173--docusaurus-2.netlify.app/

@slorber
Copy link
Collaborator

slorber commented Apr 14, 2022

seems reasonable 👍

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Apr 14, 2022
@slorber slorber changed the title fix(theme-classic): disable text-transform of codes in admonition titles fix(theme-classic): admonition title: disable text-transform on inline code blocks Apr 14, 2022
@slorber slorber merged commit f6a14db into facebook:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants