Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): lower timeout before rendering progress bar to 200ms #7142

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Close #6290. Because react-loadable sets a default timeout of 200ms, I think this makes more sense. I would agree that 1s sometimes looks like the page is lagging.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 9, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners April 9, 2022 12:00
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 9, 2022
@netlify
Copy link

netlify bot commented Apr 9, 2022

[V2]

Name Link
🔨 Latest commit a503a35
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62517564b7c7760009252474
😎 Deploy Preview https://deploy-preview-7142--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 9, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7142--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Apr 9, 2022

Size Change: -2 B (0%)

Total Size: 797 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 49.9 kB 0 B
website/build/assets/css/styles.********.css 106 kB 0 B
website/build/assets/js/main.********.js 603 kB -2 B (0%)
website/build/index.html 38.6 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena merged commit b50def3 into main Apr 9, 2022
@Josh-Cena Josh-Cena deleted the jc/lower-timeout branch April 9, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Remove delay for PendingNavigation nprogress
2 participants