feat(content-docs): make docs:version command work on localized docs #7106
+165
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7106--docusaurus-2.netlify.app/ |
|
Size Change: +1.72 kB (0%) Total Size: 805 kB
ℹ️ View Unchanged
|
Josh-Cena
added
the
status: awaiting review
slorber
approved these changes
Apr 7, 2022
| logger.interpolate`${pluginIdLogPrefix}: no docs found in path=${docsDir}.`, | ||
| ); | ||
| } else { | ||
| logger.warn`${pluginIdLogPrefix}: no docs found in path=${docsDir}. Skipping.`; |
There was a problem hiding this comment.
wonder if this message will not be too aggressive and afraid users they did something wrong
we'll see
Josh-Cena
removed
the
status: awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #7104
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested locally by creating
i18n/zh-CN/docusaurus-plugin-content-docs/current/foo.mdand runningyarn docusaurus docs:version foo. Things work as expected.