Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add FAST to showcase #7099

Closed
wants to merge 5 commits into from
Closed

docs: add FAST to showcase #7099

wants to merge 5 commits into from

Conversation

huynhicode
Copy link
Contributor

Motivation

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Run yarn start, view the changes on http://localhost:3000/showcase or http://localhost:3000/showcase?name=fast

Related PRs

None


Screenshot:

Screen Shot 2022-04-01 at 2 28 44 PM

@facebook-github-bot
Copy link
Contributor

Hi @huynhicode!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Apr 1, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit d769b15
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/624e69121506ec0008eb1fc9
😎 Deploy Preview https://deploy-preview-7099--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 60
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7099--docusaurus-2.netlify.app/

@Josh-Cena
Copy link
Collaborator

@huynhicode Please remember to sign the CLA. PRs without CLA will be closed after two weeks. Thanks!

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,

CLA signature is required

website/src/data/users.tsx Outdated Show resolved Hide resolved
website/src/data/users.tsx Outdated Show resolved Hide resolved
@huynhicode
Copy link
Contributor Author

huynhicode commented Apr 6, 2022

Thanks @Josh-Cena and @slorber for reviewing my PR.

I have made the suggested updates. Pending approval from Microsoft re: CLA.

Screen Shot 2022-04-06 at 12 13 46 PM

@Josh-Cena Josh-Cena changed the title add FAST to showcase docs: add FAST to showcase Apr 7, 2022
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 7, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 We can wait for the CLA as long as there's communication

@huynhicode
Copy link
Contributor Author

Thanks @Josh-Cena - much appreciated!

@Josh-Cena
Copy link
Collaborator

@huynhicode Any news?

@huynhicode
Copy link
Contributor Author

Hi @Josh-Cena, thanks for checking in - still pending approval for the CLA. Thanks for your patience!

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented Apr 29, 2022

@huynhicode Hi, it's been another two weeks, any news?

I can appreciate how complicated these processes in big orgs can get, so don't get too stressed about it, but still curious about any progress.

@slorber
Copy link
Collaborator

slorber commented Apr 29, 2022

This CLA friction is too annoying for site showcase submissions 😅

Trying to see if I can get approval to implement a simpler workflow where site owners would only have to comment on a GitHub issue, requesting to add their site to the showcase.

As long as it's us committing, it shouldn't require site owners to sign the CLA 🤷‍♂️

Related to #6882

@huynhicode
Copy link
Contributor Author

Hi @Josh-Cena Thanks for your patience, still pending approval.

@slorber That sounds like a great solution.

@Josh-Cena
Copy link
Collaborator

@huynhicode Is it fine if we close this PR and I send a PR myself, crediting you as co-author?

@EisenbergEffect
Copy link

@Josh-Cena If you don't mind doing that for us, that would be great. Things are stuck in a legal black box over here and I have no idea how long or if it will be resolved. /cc @huynhicode

@Josh-Cena Josh-Cena mentioned this pull request May 10, 2022
3 tasks
@Josh-Cena
Copy link
Collaborator

Thanks @EisenbergEffect I've sent #7384. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants