-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add FAST to showcase #7099
Conversation
Hi @huynhicode! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7099--docusaurus-2.netlify.app/ |
@huynhicode Please remember to sign the CLA. PRs without CLA will be closed after two weeks. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks,
CLA signature is required
Thanks @Josh-Cena and @slorber for reviewing my PR. I have made the suggested updates. Pending approval from Microsoft re: CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 We can wait for the CLA as long as there's communication
Thanks @Josh-Cena - much appreciated! |
@huynhicode Any news? |
Hi @Josh-Cena, thanks for checking in - still pending approval for the CLA. Thanks for your patience! |
@huynhicode Hi, it's been another two weeks, any news? I can appreciate how complicated these processes in big orgs can get, so don't get too stressed about it, but still curious about any progress. |
This CLA friction is too annoying for site showcase submissions 😅 Trying to see if I can get approval to implement a simpler workflow where site owners would only have to comment on a GitHub issue, requesting to add their site to the showcase. As long as it's us committing, it shouldn't require site owners to sign the CLA 🤷♂️ Related to #6882 |
Hi @Josh-Cena Thanks for your patience, still pending approval. @slorber That sounds like a great solution. |
@huynhicode Is it fine if we close this PR and I send a PR myself, crediting you as co-author? |
@Josh-Cena If you don't mind doing that for us, that would be great. Things are stuck in a legal black box over here and I have no idea how long or if it will be resolved. /cc @huynhicode |
Thanks @EisenbergEffect I've sent #7384. Please take a look. |
Motivation
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run
yarn start
, view the changes onhttp://localhost:3000/showcase
orhttp://localhost:3000/showcase?name=fast
Related PRs
None
Screenshot: