Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): route announcer #7074
feat(core): route announcer #7074
Changes from 20 commits
02db474
1af1a6c
2ada5fc
ebd259f
2c9ae8f
f271f17
df005b8
9608abe
6188ded
36a773d
a5cd567
fd8018d
6686055
75f5260
d948353
90e07e3
49e20e7
37cafa3
7cc8df3
1060785
bbb2ffb
8704767
6104fcb
4e2319d
00956fd
8833c65
7d67a48
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are other portal types planned?
What is the purpose of calling
document.createElement("docusaurus-portal");
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slorber This is the container node's tag name. Portal elements can often be custom elements so as not to have any default user-agent styles.