Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-common): use native scrolling when smooth behavior set in CSS #7057

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Mar 29, 2022

Motivation

Part of the changes in #6666

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Add scroll-behavior: smooth to the root selector

Before After
Test Test2

Related PRs

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Mar 29, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 29, 2022
@netlify
Copy link

netlify bot commented Mar 29, 2022

[V2]

Name Link
🔨 Latest commit 7bf8978
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6242d3c031c136000813a94e
😎 Deploy Preview https://deploy-preview-7057--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 29, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 56
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7057--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Mar 29, 2022

Size Change: +190 B (0%)

Total Size: 807 kB

Filename Size Change
website/build/assets/js/main.********.js 613 kB +190 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/index.html 38.4 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 4e45e14 into main Mar 29, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-btt branch March 29, 2022 10:02
@slorber
Copy link
Collaborator

slorber commented Apr 13, 2022

FYI smooth behavior was added to Safari recently so hopefully the polyfill can be removed soon!

https://caniuse.com/?search=scroll-behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants